Review Request 125072: Fix build on OS X

[Kevin Funk]

> On Sept. 8, 2015, 9 a.m., Raphael Kubo da Costa wrote:
> > Given all this effort is only used to print a debugging line, how about fixing the TODO item and doing `qDebug() << "Executing uid=" << getuid()`? I don't really see why `__uid_t` is being used in the first place.
> 
> Kevin Funk wrote:
>     Note: `getuid()` is not portable either. Not available on MSVC. Please either remove completely or wrap this line in #ifdefs...
> 
> Samuel Gaist wrote:
>     Should we provide an implementation using GetUserName https://msdn.microsoft.com/en-us/library/ms724432(VS.85).aspx for Q_OS_WIN ?

Honestly, I don't think it's worth it. It's just a debug statement after all. Just remove it altogether?


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125072/#review85000
-----------------------------------------------------------


On Sept. 7, 2015, 9:56 p.m., Samuel Gaist wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125072/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2015, 9:56 p.m.)
> 
> 
> Review request for KDE Utils and Valentin Rusu.
> 
> 
> Repository: kwalletmanager
> 
> 
> Description
> -------
> 
> like msvc, clang doesn't know about __uid_t, this patch adds it to the list
> 
> 
> Diffs
> -----
> 
>   .reviewboardrc PRE-CREATION 
>   src/konfigurator/savehelper.cpp 143142e4825c07973a72496d643881122ec5a2f3 
> 
> Diff: https://git.reviewboard.kde.org/r/125072/diff/
> 
> 
> Testing
> -------
> 
> Build on OS X 10.8
> 
> 
> Thanks,
> 
> Samuel Gaist
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150909/fc5eadff/attachment-0001.html>