Review Request 125072: Fix build on OS X

[Raphael Kubo da Costa]

> On Sept. 6, 2015, 1:07 p.m., Raphael Kubo da Costa wrote:
> > I'm not the right person to review this. Please add the "kdeutils" group to the review request and CC Valentin Rusu, kwalletmanager's maintainer.
> > 
> > Additionally, the .reviewboardrc part of this patch is unrelated with the rest, so it would be good if you sent it separately.
> 
> Samuel Gaist wrote:
>     Sorry, I picked you since you where the first listed on https://projects.kde.org/projects/kde/kdeutils/kwalletmanager
>     
>     The .reviewboardrc is a different patch. I haven't found yet how to create separeted reviews from a series of commits (or if it's possible to show here that they are separated stuff).

I would just send the .reviewboardrc part separately without worrying about series of commits (since they are not dependent anyway): just have two branches created from master and submit them separately.


- Raphael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125072/#review84892
-----------------------------------------------------------


On Sept. 8, 2015, 12:56 a.m., Samuel Gaist wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125072/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2015, 12:56 a.m.)
> 
> 
> Review request for KDE Utils and Valentin Rusu.
> 
> 
> Repository: kwalletmanager
> 
> 
> Description
> -------
> 
> like msvc, clang doesn't know about __uid_t, this patch adds it to the list
> 
> 
> Diffs
> -----
> 
>   .reviewboardrc PRE-CREATION 
>   src/konfigurator/savehelper.cpp 143142e4825c07973a72496d643881122ec5a2f3 
> 
> Diff: https://git.reviewboard.kde.org/r/125072/diff/
> 
> 
> Testing
> -------
> 
> Build on OS X 10.8
> 
> 
> Thanks,
> 
> Samuel Gaist
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150908/12fbda9c/attachment.html>