Review Request 125072: Fix build on OS X
Raphael Kubo da Costa
rakuco at FreeBSD.org
Tue Sep 8 09:00:18 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125072/#review85000
-----------------------------------------------------------
Given all this effort is only used to print a debugging line, how about fixing the TODO item and doing `qDebug() << "Executing uid=" << getuid()`? I don't really see why `__uid_t` is being used in the first place.
- Raphael Kubo da Costa
On Sept. 8, 2015, 12:56 a.m., Samuel Gaist wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125072/
> -----------------------------------------------------------
>
> (Updated Sept. 8, 2015, 12:56 a.m.)
>
>
> Review request for KDE Utils and Valentin Rusu.
>
>
> Repository: kwalletmanager
>
>
> Description
> -------
>
> like msvc, clang doesn't know about __uid_t, this patch adds it to the list
>
>
> Diffs
> -----
>
> .reviewboardrc PRE-CREATION
> src/konfigurator/savehelper.cpp 143142e4825c07973a72496d643881122ec5a2f3
>
> Diff: https://git.reviewboard.kde.org/r/125072/diff/
>
>
> Testing
> -------
>
> Build on OS X 10.8
>
>
> Thanks,
>
> Samuel Gaist
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150908/bae879c3/attachment.html>
More information about the Kde-utils-devel
mailing list