Review Request 125072: Fix build on OS X

Lindsay Roberts linds.r at gmail.com
Mon Sep 7 19:30:51 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125072/#review84968
-----------------------------------------------------------


Actually, the presence or lack thereof of `__uid_t` is unrelated to clang: clang + glibc on a linux system will have it, for instance.

Suggest using a `Q_OS_` define to select OS X or its underpinnings instead - like `Q_OS_DARWIN`.

- Lindsay Roberts


On Sept. 6, 2015, 10:42 p.m., Samuel Gaist wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125072/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2015, 10:42 p.m.)
> 
> 
> Review request for KDE Utils and Valentin Rusu.
> 
> 
> Repository: kwalletmanager
> 
> 
> Description
> -------
> 
> like msvc, clang doesn't know about __uid_t, this patch adds it to the list
> 
> 
> Diffs
> -----
> 
>   .reviewboardrc PRE-CREATION 
>   src/konfigurator/savehelper.cpp 143142e4825c07973a72496d643881122ec5a2f3 
> 
> Diff: https://git.reviewboard.kde.org/r/125072/diff/
> 
> 
> Testing
> -------
> 
> Build on OS X 10.8
> 
> 
> Thanks,
> 
> Samuel Gaist
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150907/f74c990c/attachment.html>


More information about the Kde-utils-devel mailing list