Review Request 124468: Add support for comments

[Elvis Angelaccio]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124468/#review87451
-----------------------------------------------------------


Code looks good, but I cannot apply the patch locally. Can you rebase?


part/part.cpp (line 578)
<https://git.reviewboard.kde.org/r/124468/#comment60023>

    This 4000 here scares me a little. What about setting the first widget to e.g. 2/3 of its previous height?


- Elvis Angelaccio


On Sept. 13, 2015, 6:45 p.m., Ragnar Thomsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124468/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2015, 6:45 p.m.)
> 
> 
> Review request for KDE Utils, KDE Usability, Elvis Angelaccio, and Raphael Kubo da Costa.
> 
> 
> Bugs: 328790
>     http://bugs.kde.org/show_bug.cgi?id=328790
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> Add support for reading comments in CLI-based plugins such as rar and zip. The comment is parsed from the output of ListJob. The comment is displayed below the file view in a read-only QPlainTextEdit with monospace font. A QSplitter is used so the user can resize the comment field.
> 
> Support is added to clirar, clizip and cli7z plugins. AFAIK the 7z-format doesn't support comments, but the cli7z-plugin supports reading comments in e.g. zip archives.
> 
> 
> Diffs
> -----
> 
>   kerfuffle/archive_kerfuffle.h f6ac2ea 
>   kerfuffle/archive_kerfuffle.cpp 9b10daf 
>   kerfuffle/archiveinterface.h 1aac2a4 
>   kerfuffle/archiveinterface.cpp d8a6725 
>   kerfuffle/cliinterface.h 052851a 
>   part/part.h 1d733c0 
>   part/part.cpp fbf5757 
>   plugins/cli7zplugin/cliplugin.h 9f122e4 
>   plugins/cli7zplugin/cliplugin.cpp 3915cb6 
>   plugins/clirarplugin/cliplugin.h 1832564 
>   plugins/clizipplugin/cliplugin.h 56bc06f 
>   plugins/clizipplugin/cliplugin.cpp 7eaeaaa 
> 
> Diff: https://git.reviewboard.kde.org/r/124468/diff/
> 
> 
> Testing
> -------
> 
> Tested opening zip and rar archives with comments. Tested zip archives using both clizip and cli7z plugins.
> 
> 
> File Attachments
> ----------------
> 
> Comment field at default size
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/26/e1c8c85e-fbcc-42b0-b096-f6e00494e07c__support-comments-7.png
> Comment field with expanded size
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/26/6cbac8a0-2687-4960-8c03-74717638fdd7__support-comments-6.png
> 
> 
> Thanks,
> 
> Ragnar Thomsen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20151026/47fa633e/attachment-0001.html>