[Differential] [Requested Changes To] D408: Improve error handling when loading plugins

[elvisangelaccio (Elvis Angelaccio)]

elvisangelaccio requested changes to this revision.
This revision now requires changes to proceed.

INLINE COMMENTS
  kerfuffle/archive_kerfuffle.cpp:174 You should also initialize `m_error` to `NoError` in the other constructor.
  kerfuffle/archive_kerfuffle.h:81 I miss something like `NoError` as default entry. See comments below.
  kerfuffle/archive_kerfuffle.h:142 This is fine, but I would like also a `isValid()` method, which returns true if `m_error == NoError`.
  part/part.cpp:458 Are you sure that `archive` here is always not null?
  part/part.cpp:474 Even better: `Q_ASSERT(archive && archive->isValid()`

REPOSITORY
  rARK Ark

REVISION DETAIL
  https://phabricator.kde.org/D408

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: rthomsen, elvisangelaccio
Cc: kde-utils-devel