Review Request 125518: Improve singlefileplugin's handling of .svgz files

Elvis Angelaccio elvis.angelaccio at kdemail.net
Sun Oct 4 17:46:04 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125518/#review86341
-----------------------------------------------------------

Ship it!


Please add also a comment with the bug number and a short explanation of the fix.

- Elvis Angelaccio


On Oct. 4, 2015, 5:23 p.m., Ragnar Thomsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125518/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2015, 5:23 p.m.)
> 
> 
> Review request for KDE Utils and Elvis Angelaccio.
> 
> 
> Bugs: 252701
>     http://bugs.kde.org/show_bug.cgi?id=252701
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> The singlefileplugin only knows how to properly name single files compressed with gzip, when they have the `.gz` extension. For files not ending in `.gz`, it will simply append `.uncompressed` to the filename. For `.svgz` (gzip-compressed svg's) it is better to simply remove the last `z`.
> 
> 
> Diffs
> -----
> 
>   plugins/libsinglefileplugin/singlefileplugin.cpp de679ac 
> 
> Diff: https://git.reviewboard.kde.org/r/125518/diff/
> 
> 
> Testing
> -------
> 
> Opening and extracting `.svgz` files now uses the proper `.svg` filename.
> 
> 
> Thanks,
> 
> Ragnar Thomsen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20151004/f7722dcc/attachment.html>


More information about the Kde-utils-devel mailing list