Review Request 125507: Fix header encryption in cli7z

[Ragnar Thomsen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125507/
-----------------------------------------------------------

(Updated Oct. 3, 2015, 8:27 p.m.)


Review request for KDE Utils and Elvis Angelaccio.


Repository: ark


Description
-------

7z gives an error when using the header encryptions switch (`-mhe=on|off`) with archive types that don't support header encryption such as zip. This results in Ark failing to create new zip archives with cli7z.

This is now fixed by setting `$EncryptHeaderSwitch` to empty when header encryption is off, instead of `-mhe=off`.

This patch also fixes `CreateDialog::isHeaderEncryptionChecked()` to only return true if `encryptHeaderCheckBox` is both enabled and checked, instead of just checked.


Diffs (updated)
-----

  kerfuffle/cliinterface.cpp f94bc35 
  kerfuffle/createdialog.cpp 4fb40c5 
  plugins/cli7zplugin/cliplugin.cpp 90e5bdc 

Diff: https://git.reviewboard.kde.org/r/125507/diff/


Testing
-------

* Create new zip archive with/without encryption works.
* Create new 7z archive with/without header encryption works.


Thanks,

Ragnar Thomsen

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20151003/4b9e3540/attachment-0001.html>