Review Request 125399: Enable loading alternative plugins and add executable check

[Ragnar Thomsen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125399/
-----------------------------------------------------------

(Updated Oct. 3, 2015, 12:16 p.m.)


Review request for KDE Utils, Elvis Angelaccio and Raphael Kubo da Costa.


Changes
-------

Simplify CliInterface::findExecutables() by looping through executable types. Also, no need to check all exec types if one type is not found, so return false immediately.


Repository: ark


Description
-------

Plugin loading code is reworked so Ark attempts other plugins, if first priority plugin fails. For CliPlugins, Ark now also searches for executables (as specified in ParameterList in the individual plugins) in standard path after the plugin has been loaded and if they are not found moves on to next plugin in list. It requires all four type of executables to be found (ListProgram, ExtractProgram, AddProgram and DeleteProgram). However, if the plugin is readonly (as specified by the X-KDE-Kerfuffle-ReadWrite property in the desktop file), it only requires ListProgram and ExtractProgram.

This paves the way for setting cli7z priority higher than clizip to improve unicode support. If p7zip is not installed by distributions, Ark will now automatically fallback to using the more widely-installed clizip.


Diffs (updated)
-----

  kerfuffle/archive_kerfuffle.cpp f17155c 
  kerfuffle/archiveinterface.h 1aac2a4 
  kerfuffle/archiveinterface.cpp d8a6725 
  kerfuffle/cliinterface.h e4bc6f3 
  kerfuffle/cliinterface.cpp b537f95 

Diff: https://git.reviewboard.kde.org/r/125399/diff/


Testing
-------

1. Tried moving one of the infozip executables out of path -> Ark doesn't error out, but uses cli7z plugin instead. 
2. Tried changing X-KDE-Kerfuffle-ReadWrite to false for some plugin -> Ark only searches for ListProgram and ExtractProgram.


Thanks,

Ragnar Thomsen

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20151003/0ac68cd6/attachment.html>