[Differential] [Request, 11 lines] D595: Fix crash when a zip has a folder called // and clizip is used

elvisangelaccio (Elvis Angelaccio) noreply at phabricator.kde.org
Tue Nov 24 23:24:17 UTC 2015


elvisangelaccio created this revision.
elvisangelaccio added a reviewer: rthomsen.
elvisangelaccio set the repository for this revision to rARK Ark.
elvisangelaccio added a project: Ark.
Herald added a subscriber: kde-utils-devel.

REVISION SUMMARY
  Bug 355839 is the generalization of bug 241967. 
  The fix is quite similar, but instead of just skipping entries called `//`, let's skip any entry whose filename is only made of slash characters. (i.e. `/+` in regexp terms).
  
  BUG: 355839
  FIXED-IN: 15.12.0

TEST PLAN
  Ark does not crash anymore opening the test archive. `ArchiveModel::cleanFileName` still skips entries called `.` or `/`. (would be nice to unit-test this, but that's stuff for master branch).

REPOSITORY
  rARK Ark

BRANCH
  bug/355839

REVISION DETAIL
  https://phabricator.kde.org/D595

AFFECTED FILES
  part/archivemodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, rthomsen
Cc: kde-utils-devel


More information about the Kde-utils-devel mailing list