[Differential] [Request, 4 lines] D563: AddToArchive: Do not show a messagebox with empty error message

[elvisangelaccio (Elvis Angelaccio)]

elvisangelaccio created this revision.
elvisangelaccio added a reviewer: rthomsen.
elvisangelaccio set the repository for this revision to rARK Ark.
elvisangelaccio added a project: Ark.
Herald added a subscriber: kde-utils-devel.

REVISION SUMMARY
  When the user stops an AddToArchive job (e.g. from the Notifications plasmoid),
  the `errorText()` of the stopped AddJob is empty and a meaningless KMessageBox is
  displayed. With this patch, the messagebox is created only if there is an error
  to show.
      
  As a side effect, Ark stops crashing when using cliplugins, because `emitResult()` is not
  blocked anymore by the messagebox. For the same reason, the end of the cliplugin's
  QProcess is not anymore delayed until the user closes the messagebox.
      
  Note that if there would be an error message, Ark would crash anyway.
  This is a separate issue and it's probably due to the mix of QProcess and
  QThread (see bugreport 264219).
      
  Note also the the libarchive plugin does not end at all, when the job is killed
  by the user.
      
  CCBUG: 222392

TEST PLAN
  Stopping the creation of a zip/7z/rar does not show anymore an empty error messagebox. As a side effect, the QProcess is killed as expected and Ark does not crash anymore.

REPOSITORY
  rARK Ark

BRANCH
  bug/222392

REVISION DETAIL
  https://phabricator.kde.org/D563

AFFECTED FILES
  kerfuffle/addtoarchive.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, rthomsen
Cc: kde-utils-devel