Review Request 106294: Add support for The Unarchiver command line utilities (unar/lsar) to operate on RARv3 files

Elvis Angelaccio elvis.angelaccio at kdemail.net
Thu Nov 12 15:38:12 UTC 2015



> On Sept. 13, 2015, 4:24 p.m., Elvis Angelaccio wrote:
> > Any chance to port this patch to KF5?

Btw, the latest lsar seems able to produce valid JSON, so using the Qt5 JSON parser the implementation should be much simpler.


- Elvis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/106294/#review85316
-----------------------------------------------------------


On Sept. 1, 2012, 3:30 p.m., Andrius Štikonas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/106294/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2012, 3:30 p.m.)
> 
> 
> Review request for KDE Utils.
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> This patch is based on https://svn.reviewboard.kde.org/r/6730/ (Luke Shumaker <LukeShu at sbcglobal.net>)
> 
> This patch will allow Ark to use The Unarchiver command line utilities
> (unar/lsar) to operate on RAR files, particularly RARv3.
> 
> Now, Ark selects which plugin to use based on MIME type, and the
> X-KDE-Priority of the plugin.  Unfortunately, there is currently no
> mechanism for a fallback, say one plugin doesn't work, to use
> another.  So, for right now users wishing to use Ark with RAR files
> must either choose between clirarplugin (which either uses unrar-free
> or unrar-nonfree), and cliunarchiverplugin (which uses unar and lsar),
> with Ark not being able to just detect which is installed.
> 
> To change the X-KDE-Priority, you just need to edit some .desktop
> files.  In the source they are
> `ark/plugins/*plugin/kerfuffle_*.desktop', which on many systems get
> installed to `/usr/share/kde4/services/kerfuffle_*.desktop'. The
> plugin with the highest priority is used. The clirarplugin has a
> defualt priority of 120, I've given cliunarchiverplugin a priority of
> 150.  This is probably best set by the package maintainer of an OS;
> for example, many systems will prefer unrar-nonfree, but I created
> this with Parabola in mind, on which unrar-nonfree does not exist, and
> this is the only way that RARv3 files will be opened.
> 
> Honestly though, this setup sucks, because unrar-free and unar/lsar
> both have their own stengths (basically, unar/lsar suck, but
> unrar-free doesn't work on RARv3), and the ideal setup would be to use
> unrar-free in most cases, but to fall back to unar/lsar for RARv3
> files that unrar-free can't handle.  Actually, I guess the ideal setup
> would be to make unar/lsar suck less, or to add RARv3 to rar-free.
> 
> === Known Bugs ===
> 
> The program should be able to look at which version of RAR the file
> is, but currently doesn't.  (I mean just within lsar) This is simply
> because I don't know which field to look at.
> 
> === ChangeLog (Luke Shumaker <LukeShu at sbcglobal.net>)===
> 
> 00 - Initial patch
> 01 - Enable clirar, but make cliunarchiver higher priority
> 02 - Reformat patch
> 03 - Reformat patch so that ReviewBoard recognizes it
> 
> === Changelog (Andrius Štikonas <stikonas at gmail.com>) ===
> 
> 04 - new versions of unar can extract password protected files and have
>      the ability to extract single files from the archive.
>      Make the patch compile with latest git versions of ark.
> 
> 
> Diffs
> -----
> 
>   plugins/cliunarchiverplugin/kerfuffle_cliunarchiver.desktop PRE-CREATION 
>   plugins/cliunarchiverplugin/cliplugin.cpp PRE-CREATION 
>   plugins/CMakeLists.txt 3619412 
>   plugins/cliunarchiverplugin/CMakeLists.txt PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/106294/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrius Štikonas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20151112/e1a0d7a7/attachment.html>


More information about the Kde-utils-devel mailing list