Review Request 123967: Implement a cancelled() signal in ReadOnlyArchiveInterface to fix cancellation of password dialogs

[Raphael Kubo da Costa]

> On May 31, 2015, 11:34 p.m., Raphael Kubo da Costa wrote:
> > I am assuming you have tested these new code paths. If so, please commit.
> 
> Ragnar Thomsen wrote:
>     Yes, tested as described under "Testing Done".

OK. I also suggest trying Ark's BatchExtract interface (`ark -bea`, or the Dolphin context menu): try extracting some password-protected files, canceling, getting an error message.


- Raphael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123967/#review81017
-----------------------------------------------------------


On May 31, 2015, 11:29 p.m., Ragnar Thomsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123967/
> -----------------------------------------------------------
> 
> (Updated May 31, 2015, 11:29 p.m.)
> 
> 
> Review request for KDE Utils, Elvis Angelaccio and Raphael Kubo da Costa.
> 
> 
> Bugs: 267670
>     http://bugs.kde.org/show_bug.cgi?id=267670
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> Implement a cancelled() signal in ReadOnlyArchiveInterface. This signal is emitted in CliInterface when the user cancels a password dialog. The signal is connected to a slot in Job which sets KJob::error to KJob::KilledJobError.
> 
> The callers (Part and BatchExtract) are modified to do nothing if the error code is KJob::KilledJobError when running ListJobs/ExtractJobs/AddJobs/DeleteJobs. This fixes an issue where the user cancels the "Enter password" dialog and the UI keeps being blocked and/or error messageboxes appear.
> 
> The commit ee006cb6a83e6cbd01a2dc459b8b0c8be664c05e in the frameworks branch should be reverted before applying this diff, since this is meant to be an improved replacement of that commit.
> 
> 
> Diffs
> -----
> 
>   kerfuffle/archiveinterface.h 3126a4c 
>   kerfuffle/cliinterface.cpp 089f36c 
>   kerfuffle/jobs.h 5e177d3 
>   kerfuffle/jobs.cpp 061b75e 
>   part/part.cpp fa1688e 
> 
> Diff: https://git.reviewboard.kde.org/r/123967/diff/
> 
> 
> Testing
> -------
> 
> Opened a password-protected zip archive, clicked on a file and cancelled the dialog. Opened a password-protected zip archive, selected a file for extraction and cancelled the password dialog. Opened a password-protected rar archive, and cancelled the password dialog. In all cases, the UI is not blocked after cancelling the dialog and no message boxes appear.
> 
> 
> Thanks,
> 
> Ragnar Thomsen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150531/6a144d92/attachment-0001.html>