Review Request 122376: libarchive: throw error on extracting fail

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122376/#review81009
-----------------------------------------------------------


Thanks for the patch. I am trying to handle this problem more generically in the libarchive code in review request 123832. I believe it supercedes the work done here.

- Raphael Kubo da Costa


On Feb. 2, 2015, 11:08 a.m., Boris Egorov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122376/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2015, 11:08 a.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Bugs: 206383
>     http://bugs.kde.org/show_bug.cgi?id=206383
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> Ark can't continue extraction after libarchive fail anyway, so let's instead throw an error. Such error can appear when disk is full, for example. Error progpagated to UI and shown to user. Error message currently a little verbose ("Cannot extract file.txt: Can't create 'file.txt'") for now.
> 
> 
> Diffs
> -----
> 
>   plugins/libarchive/libarchivehandler.cpp 0fba528 
> 
> Diff: https://git.reviewboard.kde.org/r/122376/diff/
> 
> 
> Testing
> -------
> 
> Make sure build is fine, then:
> 
> dd if=/dev/zero of=linux-ark bs=1024 count=100
> sudo mke2fs linux-ark
> sudo mount tmp/linux-ark /mnt/
> cd /mnt
> mkdir extract
> ark -b -o extract /path/to/some/archive.zip
> 
> 
> Thanks,
> 
> Boris Egorov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150531/04bbe5c6/attachment.html>