Review Request 123832: libarchive: Improve the handling of archive_write_header() errors.

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123832/
-----------------------------------------------------------

(Updated May 17, 2015, 8:47 p.m.)


Review request for KDE Utils and Raphael Kubo da Costa.


Changes
-------

More callers of `archive_write_header()` updated.


Bugs: 335411
    http://bugs.kde.org/show_bug.cgi?id=335411


Repository: ark


Description (updated)
-------

Errors while extracting an archive entry in copyFiles() were being
discarded without informing the user, who would then believe the entire
extraction had worked correctly. We now emit the error() signal when
there is an error and cancel the extraction.

Other callers of archive_write_header() have also been modified to use
the same coding style (handling errors in a switch()) and error message
format for consistency and ease of future maintenance.

Additionally, none of the error messages use archive_error_string()
anymore. While this means the messages are less detailed, it also means
users who use a translated KDE will not see part of the error messages
hardcoded in English.


Diffs (updated)
-----

  plugins/libarchive/libarchivehandler.cpp 75cf759d5e67508288ee6a42d42b4c0d6b557afe 

Diff: https://git.reviewboard.kde.org/r/123832/diff/


Testing
-------

Creating archives still works as before, and error messages during extraction (such as the one in bug 335411) are properly reported.


Thanks,

Raphael Kubo da Costa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150517/7fa6f868/attachment.html>