Review Request 123832: libarchive: Improve the handling of archive_write_header() errors.

[Raphael Kubo da Costa]

> On May 17, 2015, 7:46 p.m., Raphael Kubo da Costa wrote:
> > I'm sending this review request to gather feedback from the usability group on the UI changes this patch makes:
> > * Dropping use of `archive_error_string()` in the error messages. While on the error messages become less precise, using that function adds a piece of English text coming from libarchive to user-facing messages that are translated and lead to an ugly mixture of English and other languages in the same sentence. Additionally, `archive_error_string()` possibly returns a string that make more sense to the programmer than to users. If this makes sense I may change other error messages that make use of that function too.
> > * The actual contents of the error messages. Are they good enough?
> > * The decision to stop extracting/compressing when the first error is encountered, even if it is possible to proceed. I'm doing this because currently there is no good way to show a series of errors in the UI.

Ugh, the Markdown formatting of the previous comment got completely messed up and I am unable to edit or delete that comment. What's in italic is supposed to be one bullet point, and the final sentences not in italic are another one.


- Raphael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123832/#review80528
-----------------------------------------------------------


On May 17, 2015, 7:41 p.m., Raphael Kubo da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123832/
> -----------------------------------------------------------
> 
> (Updated May 17, 2015, 7:41 p.m.)
> 
> 
> Review request for KDE Utils, KDE Usability and Raphael Kubo da Costa.
> 
> 
> Bugs: 335411
>     http://bugs.kde.org/show_bug.cgi?id=335411
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> Errors while extracting an archive entry in copyFiles() were being
> discarded without informing the user, who would then believe the entire
> extraction had worked correctly. We now emit the error() signal when
> there is an error and cancel the extraction.
> 
> It also makes sense to adapt the code in writeFile() to the same format
> of using a switch() to test archive_write_header()'s return code to ease
> future maintenance.
> 
> Additionally, none of the error messages use archive_error_string()
> anymore. While this means the messages are less detailed, it also means
> users who use a translated KDE will not see part of the error messages
> hardcoded in English.
> 
> 
> Diffs
> -----
> 
>   plugins/libarchive/libarchivehandler.cpp 75cf759d5e67508288ee6a42d42b4c0d6b557afe 
> 
> Diff: https://git.reviewboard.kde.org/r/123832/diff/
> 
> 
> Testing
> -------
> 
> Creating archives still works as before, and error messages during extraction (such as the one in bug 335411) are properly reported.
> 
> 
> Thanks,
> 
> Raphael Kubo da Costa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150517/632af201/attachment.html>