Review Request 123771: [Ark] Port to QApplication, QCommandLineParser and KAboutMenu.

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123771/#review80294
-----------------------------------------------------------



app/main.cpp (line 108)
<https://git.reviewboard.kde.org/r/123771/#comment55084>

    Already done by KAboutData::setApplicationData
    
    => remove them.



app/main.cpp (line 113)
<https://git.reviewboard.kde.org/r/123771/#comment55081>

    Remove it



app/main.cpp (line 114)
<https://git.reviewboard.kde.org/r/123771/#comment55080>

    QStringLiteral
    
    and use application.setWindowIcon no ?



app/main.cpp (line 128)
<https://git.reviewboard.kde.org/r/123771/#comment55082>

    Better to use QStringLiteral when it's a string.



app/main.cpp (line 166)
<https://git.reviewboard.kde.org/r/123771/#comment55083>

    why ?


- Laurent Montel


On mai 13, 2015, 11:55 matin, Ragnar Thomsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123771/
> -----------------------------------------------------------
> 
> (Updated mai 13, 2015, 11:55 matin)
> 
> 
> Review request for KDE Utils, Bhushan Shah, Lukáš Tinkl, Laurent Montel, and Raphael Kubo da Costa.
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> Started porting of main.cpp to ultimately remove dependency on KDELibs4Support.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 363a751 
>   app/CMakeLists.txt bfed07a 
>   app/main.cpp 0fa72a9 
>   app/org.kde.ark.desktop.cmake e9c5973 
> 
> Diff: https://git.reviewboard.kde.org/r/123771/diff/
> 
> 
> Testing
> -------
> 
> Tested by opening and extracting various archive types. Tested opening local and remote URLs from commandline.
> 
> 
> Thanks,
> 
> Ragnar Thomsen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150513/50b063dd/attachment.html>