Review Request 124050: [Ark] Check if file exists before attempting to preview it

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124050/#review81335
-----------------------------------------------------------


What backtrace are you getting for your crash?

I've just tried the KDE4 version with the file you mentioned and it does not crash, though the previewed file is shown as a new file instead.


part/arkviewer.cpp (line 101)
<https://git.reviewboard.kde.org/r/124050/#comment55729>

    Wrong coding style: missing a space after the `if`.



part/arkviewer.cpp (line 103)
<https://git.reviewboard.kde.org/r/124050/#comment55730>

    User messages should never have exclamation marks.


- Raphael Kubo da Costa


On June 9, 2015, 5:36 p.m., Ragnar Thomsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124050/
> -----------------------------------------------------------
> 
> (Updated June 9, 2015, 5:36 p.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> Attempting to preview a file that doesn't exist in the temporary directory crashes Ark. Ideally, this should not happen because only files that exist in an archive should be presented in the QTreeView. However, for the clizip plugin at least, files with filenames containing special characters cause this plugin to not find the file and hence not extract it, and Ark crashes attempting to view it.
> 
> This patch adds a simple check to see if the file exists in the temporary directory before attempting to view it. If the file doesn't exist (e.g. could not be extracted by clizip), a KMessageBox::error() is displayed. Also an error is printed in console output.
> 
> 
> Diffs
> -----
> 
>   part/arkviewer.cpp 2276c5e 
> 
> Diff: https://git.reviewboard.kde.org/r/124050/diff/
> 
> 
> Testing
> -------
> 
> Tested with the Zip archive provided in https://bugs.kde.org/show_bug.cgi?id=345519.
> 
> 
> Thanks,
> 
> Ragnar Thomsen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150609/1e9462f6/attachment.html>