Review Request 121997: Implement configuration dialog in Ark

Thu Jun 4 15:54:45 UTC 2015

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121997/#review81186
-----------------------------------------------------------


app/mainwindow.cpp (lines 296 - 297)
<https://git.reviewboard.kde.org/r/121997/#comment55590>

    This is the most confusing part to me in this patch. The relationship between the `*Page` classes, their `*Setting` counterparts and `MainWindow` is quite odd:
    
    * The `Page` classes do not use any `QObject` capabilities and the `parent` they get in their constructors are not used anywhere even though it is required by `Interface::configPages()`.
    * Their `widget()` methods then take _another_ `parent` and act like factories.
    * ... however, `KConfigDialog::addPage()` will reparent those widgets again since `manage == true`.
    
    What if you get rid of the `Page` classes, move the icon and name information to the dialog classes andpass fewer `parent`s around?


app/mainwindow.cpp (line 299)
<https://git.reviewboard.kde.org/r/121997/#comment55588>

    Please capitalize the first letter and end the sentence with a period ('.').


app/mainwindow.cpp (line 308)
<https://git.reviewboard.kde.org/r/121997/#comment55587>

    If `dialogName` is not used, why not remove it from the method signature?


part/CMakeLists.txt (line 10)
<https://git.reviewboard.kde.org/r/121997/#comment55578>

    Minor nitpick: this file list is unsorted; there's no need to sort it in this commit, but the new entry could be added to the beginning of the list.


part/CMakeLists.txt (lines 17 - 18)
<https://git.reviewboard.kde.org/r/121997/#comment55579>

    Ditto about sorting.


part/arkconfigpage.h (line 32)
<https://git.reviewboard.kde.org/r/121997/#comment55580>

    Extra empty line.


part/arkconfigpage.h (lines 36 - 37)
<https://git.reviewboard.kde.org/r/121997/#comment55586>

    I don't see why `name` and `iconName` need to be virtual.


part/arkconfigpage.h (line 40)
<https://git.reviewboard.kde.org/r/121997/#comment55581>

    Extra empty line.


part/dialogs/extractionsettings.h (line 29)
<https://git.reviewboard.kde.org/r/121997/#comment55583>

    Aren't you missing a `Q_OBJECT` here?


part/dialogs/previewsettings.h (line 29)
<https://git.reviewboard.kde.org/r/121997/#comment55584>

    And here.


part/dialogs/previewsettings.h (line 38)
<https://git.reviewboard.kde.org/r/121997/#comment55585>

    Extra empty line.


part/interface.h (line 41)
<https://git.reviewboard.kde.org/r/121997/#comment55582>

    Don't you need to bump the version number here?


- Raphael Kubo da Costa


On June 4, 2015, 4:14 p.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121997/
> -----------------------------------------------------------
> 
> (Updated June 4, 2015, 4:14 p.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Bugs: 165314
>     http://bugs.kde.org/show_bug.cgi?id=165314
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> This patch implements the standard Configuration Dialog (i.e. using `KConfigDialog`) in Ark, as one would expect from a KDE application. 
> This feature has been requested in more than one bug. I choosed to target bug 165314 since the others are more like "add the config dialog to implement the feature *foo*".
> 
> The widgets showed in the config dialog are provided by the Ark `Part` interface (just one widget for now). This should help to show the Ark settings in, for instance, Konqueror's config dialog. A similar approach is done in Kate and Cantor, from what I have seen.
> 
> I don't like very much the `document-save` icon used for the Extraction page, but I couldn't find any better.
> 
> 
> Diffs
> -----
> 
>   app/mainwindow.h f2366c8bd047e3484daa4eabeb4f4b790c437c4a 
>   app/mainwindow.cpp 470b72d00d0544662f2c1f10dbc0638b99f993af 
>   kerfuffle/ark.kcfg 97d2086688698e96c429def089c50ff3cdbe4c4e 
>   part/CMakeLists.txt cca6d25e1941cecde07d0cd342cc2602fbc5235e 
>   part/arkconfigpage.h PRE-CREATION 
>   part/arkconfigpage.cpp PRE-CREATION 
>   part/dialogs/extractionsettings.h PRE-CREATION 
>   part/dialogs/extractionsettings.ui PRE-CREATION 
>   part/dialogs/previewsettings.h PRE-CREATION 
>   part/dialogs/previewsettings.ui PRE-CREATION 
>   part/interface.h 40f590284502d23a2a4ffaa333bfd5b63e6ec773 
>   part/part.h 4c81da5541c1143ad4cfe9093f9c307145ac561e 
>   part/part.cpp ee7f75ff9acd8ea3c72aa5a400d713ffc6d1c7c4 
> 
> Diff: https://git.reviewboard.kde.org/r/121997/diff/
> 
> 
> Testing
> -------
> 
> Compile and run, then try to change some settings and check that they persist.
> 
> 
> File Attachments
> ----------------
> 
> extraction-settings.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/06/03/3dfe3110-4f46-4c14-9b19-79060577a4c9__extraction-settings.png
> preview-settings1.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/06/04/8a1600b1-64a7-43fa-87e8-0c84e054d801__preview-settings1.png
> preview-settings2.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/06/04/f687f5ea-3f2e-48b0-b204-92e3fbdf23e7__preview-settings2.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150604/bede7d5c/attachment-0001.html>