Review Request 121997: Implement configuration dialog in Ark

[Elvis Angelaccio]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121997/
-----------------------------------------------------------

(Updated June 4, 2015, 1:14 p.m.)


Review request for KDE Utils and Raphael Kubo da Costa.


Changes
-------

* Fixed settings not being updated in the config dialog after having changed them in the extraction dialog.
* Fixed the other minor issues as discussed.


Bugs: 165314
    http://bugs.kde.org/show_bug.cgi?id=165314


Repository: ark


Description
-------

This patch implements the standard Configuration Dialog (i.e. using `KConfigDialog`) in Ark, as one would expect from a KDE application. 
This feature has been requested in more than one bug. I choosed to target bug 165314 since the others are more like "add the config dialog to implement the feature *foo*".

The widgets showed in the config dialog are provided by the Ark `Part` interface (just one widget for now). This should help to show the Ark settings in, for instance, Konqueror's config dialog. A similar approach is done in Kate and Cantor, from what I have seen.

I don't like very much the `document-save` icon used for the Extraction page, but I couldn't find any better.


Diffs (updated)
-----

  app/mainwindow.h f2366c8bd047e3484daa4eabeb4f4b790c437c4a 
  app/mainwindow.cpp 470b72d00d0544662f2c1f10dbc0638b99f993af 
  kerfuffle/ark.kcfg 97d2086688698e96c429def089c50ff3cdbe4c4e 
  part/CMakeLists.txt cca6d25e1941cecde07d0cd342cc2602fbc5235e 
  part/arkconfigpage.h PRE-CREATION 
  part/arkconfigpage.cpp PRE-CREATION 
  part/dialogs/extractionsettings.h PRE-CREATION 
  part/dialogs/extractionsettings.ui PRE-CREATION 
  part/dialogs/previewsettings.h PRE-CREATION 
  part/dialogs/previewsettings.ui PRE-CREATION 
  part/interface.h 40f590284502d23a2a4ffaa333bfd5b63e6ec773 
  part/part.h 4c81da5541c1143ad4cfe9093f9c307145ac561e 
  part/part.cpp ee7f75ff9acd8ea3c72aa5a400d713ffc6d1c7c4 

Diff: https://git.reviewboard.kde.org/r/121997/diff/


Testing
-------

Compile and run, then try to change some settings and check that they persist.


File Attachments (updated)
----------------

extraction-settings.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/06/03/3dfe3110-4f46-4c14-9b19-79060577a4c9__extraction-settings.png
preview-settings1.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/06/04/8a1600b1-64a7-43fa-87e8-0c84e054d801__preview-settings1.png
preview-settings2.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/06/04/f687f5ea-3f2e-48b0-b204-92e3fbdf23e7__preview-settings2.png


Thanks,

Elvis Angelaccio

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150604/933fb945/attachment-0001.html>