Review Request 123980: [Ark] Improve hide/show logic for information panel

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123980/#review81175
-----------------------------------------------------------

Ship it!


Looks great now, thanks! I hadn't realized we were storing two separate IntLists already.

- Raphael Kubo da Costa


On June 4, 2015, 11:20 a.m., Ragnar Thomsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123980/
> -----------------------------------------------------------
> 
> (Updated June 4, 2015, 11:20 a.m.)
> 
> 
> Review request for KDE Utils, Elvis Angelaccio and Raphael Kubo da Costa.
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> The logic governing hiding/showing of the infopanel as well as storing/retrieving the size of the QSplitter was reworked into a more intuitive and simple approach. A configuration option "showInfoPanel" of type bool was added, which stores whether or not the infopanel should be shown. The option "splitterSizesWithBothWidgets" was removed, since it's no longer needed. Default values of "splitterSizes" are now set in the kcfg file, instead of in the C++ code.
> 
> 
> Diffs
> -----
> 
>   kerfuffle/ark.kcfg 0c22014 
>   part/part.h 6afd90f 
>   part/part.cpp 7261631 
> 
> Diff: https://git.reviewboard.kde.org/r/123980/diff/
> 
> 
> Testing
> -------
> 
> Show/hide the information panel via the Settings menu works as expected. Ark remembers whether or not it was shown after closing/opening the program. The sizes of the splitter are also remembered after hiding/showing and after program restart. Deleting the splitterSizes line in ~/.config/arkrc and opening Ark results in the default sizes of 200/100 being used.
> 
> 
> Thanks,
> 
> Ragnar Thomsen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150604/390838d4/attachment.html>