Review Request 123980: [Ark] Improve hide/show logic for information panel

[Ragnar Thomsen]

> On June 2, 2015, 6:43 p.m., Raphael Kubo da Costa wrote:
> > Separating bug fixes from new features is always wise.
> > 
> > In this case, the problem your other commit introduced can be fixed by just calling `QSplitter::setSizes()` after adding the widgets, just like it was done before. Suddenly your patch gets much smaller, self-contained and with much fewer risk of introducing new bugs :-)
> > 
> > Once we have something that is finally working properly, we can worry about other changes like switching from an IntList to a boolean and things like that.
> 
> Ragnar Thomsen wrote:
>     Thanks, I'll remember that for the next time :)
> 
> Raphael Kubo da Costa wrote:
>     Actually, I'd like to do it this time to avoid introducing new bugs. A new RR could fix the bug, and this one just introduces these cosmetic changes to the code that are not that urgent.

I fixed the bug separately in this commit: [271484338a415d93e4870029a33c3503392740ce](http://quickgit.kde.org/?p=ark.git&a=commit&h=271484338a415d93e4870029a33c3503392740ce)

Since it was moving a single line of code, it seemed overkill to open a RR for it.


- Ragnar


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123980/#review81083
-----------------------------------------------------------


On June 3, 2015, 3:43 p.m., Ragnar Thomsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123980/
> -----------------------------------------------------------
> 
> (Updated June 3, 2015, 3:43 p.m.)
> 
> 
> Review request for KDE Utils, Elvis Angelaccio and Raphael Kubo da Costa.
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> The logic governing hiding/showing of the infopanel as well as storing/retrieving the size of the QSplitter was reworked into a more intuitive and simple approach. A configuration option "showInfoPanel" of type bool was added, which stores whether or not the infopanel should be shown. The option "splitterSizesWithBothWidgets" was removed, since it's no longer needed. Default values of "splitterSizes" are now set in the kcfg file, instead of in the C++ code.
> 
> 
> Diffs
> -----
> 
>   kerfuffle/ark.kcfg 0c22014 
>   part/part.h 6afd90f 
>   part/part.cpp 7261631 
> 
> Diff: https://git.reviewboard.kde.org/r/123980/diff/
> 
> 
> Testing
> -------
> 
> Show/hide the information panel via the Settings menu works as expected. Ark remembers whether or not it was shown after closing/opening the program. The sizes of the splitter are also remembered after hiding/showing and after program restart. Deleting the splitterSizes line in ~/.config/arkrc and opening Ark results in the default sizes of 200/100 being used.
> 
> 
> Thanks,
> 
> Ragnar Thomsen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150603/103e597f/attachment.html>