Review Request 121231: ark: suppress preview on large files

[Raphael Kubo da Costa]

> On June 3, 2015, 2:11 p.m., Raphael Kubo da Costa wrote:
> > New settings are introduced but there's no UI to control their values, right? In that case, isn't it better to just check the file size and ask the user before previewing?
> 
> Ragnar Thomsen wrote:
>     I think we should merge the "Configuration dialog" (https://git.reviewboard.kde.org/r/121997/) before 15.08. In that case there will be a UI to control the values...
> 
> Elvis Angelaccio wrote:
>     Yes, I could update the settings dialog's RR to actually introduce these new settings.
> 
> Ragnar Thomsen wrote:
>     Great Elvis. [121997](https://git.reviewboard.kde.org/r/121997/) also needs rebasing against frameworks branch. Do you have time for this? Otherwise I could help...
> 
> Raphael Kubo da Costa wrote:
>     Either that or changing this RR... Right now the worst order was chosen and right now users will just be surprised that some files will not be previewed.
> 
> Ragnar Thomsen wrote:
>     But "users" are supposed to be running released versions of Ark.

If you land feature B that should have been committed after feature A which has not landed yet, there's always a risk that a deadline is missed and we ship something incomplete to the users. This is probably not going to be the case here since you and Elvis seem to have the time and energy to get everything ready, but I wouldn't like to start doing that for other features too.


- Raphael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121231/#review81112
-----------------------------------------------------------


On June 3, 2015, 2:28 p.m., Boris Egorov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121231/
> -----------------------------------------------------------
> 
> (Updated June 3, 2015, 2:28 p.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Bugs: 139389
>     http://bugs.kde.org/show_bug.cgi?id=139389
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> Do not preview large files
> 
> 
> Diffs
> -----
> 
>   kerfuffle/ark.kcfg 97d2086 
>   part/part.cpp 87afb49 
> 
> Diff: https://git.reviewboard.kde.org/r/121231/diff/
> 
> 
> Testing
> -------
> 
> Build ark, make sure that files larger than specified limit is not previewed.
> 
> 
> Thanks,
> 
> Boris Egorov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150603/5ccfc592/attachment.html>