Review Request 121231: ark: suppress preview on large files

[Elvis Angelaccio]

> On Giu. 3, 2015, 11:11 a.m., Raphael Kubo da Costa wrote:
> > New settings are introduced but there's no UI to control their values, right? In that case, isn't it better to just check the file size and ask the user before previewing?
> 
> Ragnar Thomsen wrote:
>     I think we should merge the "Configuration dialog" (https://git.reviewboard.kde.org/r/121997/) before 15.08. In that case there will be a UI to control the values...

Yes, I could update the settings dialog's RR to actually introduce these new settings.


- Elvis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121231/#review81112
-----------------------------------------------------------


On Giu. 3, 2015, 10:22 a.m., Boris Egorov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121231/
> -----------------------------------------------------------
> 
> (Updated Giu. 3, 2015, 10:22 a.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Bugs: 139389
>     http://bugs.kde.org/show_bug.cgi?id=139389
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> Do not preview large files
> 
> 
> Diffs
> -----
> 
>   kerfuffle/ark.kcfg 97d2086 
>   part/part.cpp 87afb49 
> 
> Diff: https://git.reviewboard.kde.org/r/121231/diff/
> 
> 
> Testing
> -------
> 
> Build ark, make sure that files larger than specified limit is not previewed.
> 
> 
> Thanks,
> 
> Boris Egorov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150603/410d4628/attachment.html>