Review Request 121231: ark: suppress preview on large files

[Boris Egorov]

> On June 3, 2015, 9:56 a.m., Ragnar Thomsen wrote:
> > part/part.cpp, line 381
> > <https://git.reviewboard.kde.org/r/121231/diff/1/?file=329666#file329666line381>
> >
> >     Nitpick: Please write out "size" in sz and maxPreviewSz. Saving two letters isn't worth the loss in readability :)

Ok, done!
I was trying to fit into 80 characters width, but I agree, 'size' is much readable than 'sz'.


- Boris


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121231/#review81108
-----------------------------------------------------------


On June 3, 2015, 10:22 a.m., Boris Egorov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121231/
> -----------------------------------------------------------
> 
> (Updated June 3, 2015, 10:22 a.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Bugs: 139389
>     http://bugs.kde.org/show_bug.cgi?id=139389
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> Do not preview large files
> 
> 
> Diffs
> -----
> 
>   kerfuffle/ark.kcfg 97d2086 
>   part/part.cpp 87afb49 
> 
> Diff: https://git.reviewboard.kde.org/r/121231/diff/
> 
> 
> Testing
> -------
> 
> Build ark, make sure that files larger than specified limit is not previewed.
> 
> 
> Thanks,
> 
> Boris Egorov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150603/3201ca5b/attachment-0001.html>