Review Request 121231: ark: suppress preview on large files

[Ragnar Thomsen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121231/#review81108
-----------------------------------------------------------


I tested this with frameworks branch and it works as expected. I think it is a great idea, and when we merge the configuration dialog (see /r/121997) we can add these settings to to dialog. I think we can merge this now into the frameworks branch.


part/part.cpp (line 381)
<https://git.reviewboard.kde.org/r/121231/#comment55535>

    Nitpick: Please write out "size" in sz and maxPreviewSz. Saving two letters isn't worth the loss in readability :)


- Ragnar Thomsen


On Nov. 24, 2014, 7:22 p.m., Boris Egorov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121231/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2014, 7:22 p.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Bugs: 139389
>     http://bugs.kde.org/show_bug.cgi?id=139389
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> Do not preview large files
> 
> 
> Diffs
> -----
> 
>   kerfuffle/ark.kcfg 97d2086 
>   part/part.cpp 4d5b42f 
> 
> Diff: https://git.reviewboard.kde.org/r/121231/diff/
> 
> 
> Testing
> -------
> 
> Build ark, make sure that files larger than specified limit is not previewed.
> 
> 
> Thanks,
> 
> Boris Egorov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150603/e5447c92/attachment.html>