Review Request 123980: [Ark] Fix the information panel

[Ragnar Thomsen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123980/
-----------------------------------------------------------

(Updated June 2, 2015, 10:22 a.m.)


Review request for KDE Utils, Elvis Angelaccio and Raphael Kubo da Costa.


Changes
-------

Updated description to include info on which commit broke the show/hide logic.


Repository: ark


Description (updated)
-------

This patch fixes and reworks the logic governing hiding/showing of the infopanel as well as storing/retrieving the size of the QSplitter was reworked into a more intuitive and simple approach. A configuration option "showInfoPanel" of type bool was added, which stores whether or not the infopanel should be shown. The option "splitterSizesWithBothWidgets" was removed, since it's no longer needed. Default values of "splitterSizes" are now set in the kcfg file, instead of in the C++ code.

The infopanel show/hide logic has been broken in the frameworks branch since commit b1ce0d272cff155fff54ca6d7cb90f90b9075490


Diffs
-----

  kerfuffle/ark.kcfg 97d2086 
  part/part.h 6afd90f 
  part/part.cpp 6fc9f55 

Diff: https://git.reviewboard.kde.org/r/123980/diff/


Testing
-------

Show/hide the information panel via the Settings menu works as expected. Ark remembers whether or not it was shown after closing/opening the program. The sizes of the splitter are also remembered after hiding/showing and after program restart. Deleting the splitterSizes line in ~/.config/arkrc and opening Ark results in the default sizes of 200/100 being used.


Thanks,

Ragnar Thomsen

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150602/0677758a/attachment.html>