Review Request 124468: Add support for comments

[Thomas Pfeiffer]

> On July 26, 2015, 4:30 p.m., Thomas Pfeiffer wrote:
> > Ah yes, that works perfectly well, good idea!
> > +1 from the usability side,

(sorry, accidentally clicked "Publish" too soon)
+1 from the usability side, now please wait for the technical review.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124468/#review82998
-----------------------------------------------------------


On July 26, 2015, 2:42 p.m., Ragnar Thomsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124468/
> -----------------------------------------------------------
> 
> (Updated July 26, 2015, 2:42 p.m.)
> 
> 
> Review request for KDE Utils, KDE Usability, Elvis Angelaccio, and Raphael Kubo da Costa.
> 
> 
> Bugs: 328790
>     http://bugs.kde.org/show_bug.cgi?id=328790
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> Add support for reading comments in CLI-based plugins such as rar and zip. The comment is parsed from the output of ListJob. The comment is displayed below the file view in a read-only QPlainTextEdit with monospace font. A QSplitter is used so the user can resize the comment field.
> 
> Support is added to clirar, clizip and cli7z plugins. AFAIK the 7z-format doesn't support comments, but the cli7z-plugin supports reading comments in e.g. zip archives.
> 
> 
> Diffs
> -----
> 
>   kerfuffle/archive_kerfuffle.h f6fbbd8 
>   kerfuffle/archive_kerfuffle.cpp 7b9990d 
>   kerfuffle/archiveinterface.h 1aac2a4 
>   kerfuffle/cliinterface.h 50c9e36 
>   kerfuffle/cliinterface.cpp 2f5d607 
>   part/part.h 5098bd5 
>   part/part.cpp da26a5b 
>   plugins/cli7zplugin/cliplugin.cpp 51480bc 
>   plugins/clirarplugin/cliplugin.cpp 62d2078 
>   plugins/clizipplugin/cliplugin.cpp db8dcea 
> 
> Diff: https://git.reviewboard.kde.org/r/124468/diff/
> 
> 
> Testing
> -------
> 
> Tested opening zip and rar archives with comments.
> 
> 
> File Attachments
> ----------------
> 
> Comment field at default size
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/26/e1c8c85e-fbcc-42b0-b096-f6e00494e07c__support-comments-7.png
> Comment field with expanded size
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/26/6cbac8a0-2687-4960-8c03-74717638fdd7__support-comments-6.png
> 
> 
> Thanks,
> 
> Ragnar Thomsen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150726/2f6f4239/attachment.html>