Review Request 124442: Improve detection of mimetype

[Ragnar Thomsen]

On July 25, 2015, 4:24 p.m., Ragnar Thomsen wrote:
> > Works for me, but what happens if the file is not readable?
> 
> Ragnar Thomsen wrote:
>     Then Ark fails to identify the mimetype and the default mimetype of application/octet-stream is used. I will look into this...

With diff rev. 3, we check for readability of archive instead of existence. Ark lacks proper checks for if archives are readable, but this should be fixed separately.


- Ragnar


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124442/#review82944
-----------------------------------------------------------


On July 26, 2015, 1:37 p.m., Ragnar Thomsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124442/
> -----------------------------------------------------------
> 
> (Updated July 26, 2015, 1:37 p.m.)
> 
> 
> Review request for KDE Utils, Elvis Angelaccio and Raphael Kubo da Costa.
> 
> 
> Bugs: 265971
>     http://bugs.kde.org/show_bug.cgi?id=265971
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> This patch improves the mimetype detection when opening archives. Previously, the filename extension had higher priority than file content when determining mimetype. When opening an archive that had a wrong extension (as in bug 265971), this resulted in Ark failing to open it.
> 
> With this patch the mimetype is determined from file content. Additionally, a warning is shown in console output when mimetype from extension and content do not match.
> 
> 
> Diffs
> -----
> 
>   kerfuffle/archive_kerfuffle.cpp 7b9990d 
> 
> Diff: https://git.reviewboard.kde.org/r/124442/diff/
> 
> 
> Testing
> -------
> 
> Opening archives with wrong filename extensions now works as expected.
> 
> 
> Thanks,
> 
> Ragnar Thomsen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150726/ce6c0721/attachment.html>