Review Request 124442: Improve detection of mimetype

[Ragnar Thomsen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124442/
-----------------------------------------------------------

(Updated July 26, 2015, 1:37 p.m.)


Review request for KDE Utils, Elvis Angelaccio and Raphael Kubo da Costa.


Changes
-------

Instead of checking if the file exists, check if it's readable.


Bugs: 265971
    http://bugs.kde.org/show_bug.cgi?id=265971


Repository: ark


Description
-------

This patch improves the mimetype detection when opening archives. Previously, the filename extension had higher priority than file content when determining mimetype. When opening an archive that had a wrong extension (as in bug 265971), this resulted in Ark failing to open it.

With this patch the mimetype is determined from file content. Additionally, a warning is shown in console output when mimetype from extension and content do not match.


Diffs (updated)
-----

  kerfuffle/archive_kerfuffle.cpp 7b9990d 

Diff: https://git.reviewboard.kde.org/r/124442/diff/


Testing
-------

Opening archives with wrong filename extensions now works as expected.


Thanks,

Ragnar Thomsen

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150726/1fad73e6/attachment.html>