Review Request 124468: Add support for comments

[Ragnar Thomsen]

> On July 26, 2015, 10:08 a.m., Kai Uwe Broulik wrote:
> > I would suggest showing the comment in a sidebar (cf. WinRAR) so it's visible right away.
> 
> Kai Uwe Broulik wrote:
>     Also since the comment might be really long, it needs to be scrollable (and selectable), so a message box doesn't really work for this imho.

Please see response to Thomas Pfeiffer's comment...


- Ragnar


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124468/#review82973
-----------------------------------------------------------


On July 26, 2015, 1:20 a.m., Ragnar Thomsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124468/
> -----------------------------------------------------------
> 
> (Updated July 26, 2015, 1:20 a.m.)
> 
> 
> Review request for KDE Utils, KDE Usability, Elvis Angelaccio, and Raphael Kubo da Costa.
> 
> 
> Bugs: 328790
>     http://bugs.kde.org/show_bug.cgi?id=328790
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> Add support for reading comments in CLI-based plugins such as rar and zip. The comment is parsed from the output of ListJob. If a comment is available, a dismissible KMessagewidget is shown with a "Show comment" button. The comment can also be accessed from the Action menu.
> 
> Support is added to clirar, clizip and cli7z plugins. AFAIK the 7z-format doesn't support comments, but the cli7z-plugin supports reading comments in e.g. zip archives.
> 
> 
> Diffs
> -----
> 
>   kerfuffle/archive_kerfuffle.h f6fbbd8 
>   kerfuffle/archive_kerfuffle.cpp 7b9990d 
>   kerfuffle/archiveinterface.h 1aac2a4 
>   kerfuffle/cliinterface.h 50c9e36 
>   kerfuffle/cliinterface.cpp 2f5d607 
>   part/ark_part.rc da04d47 
>   part/part.h 5098bd5 
>   part/part.cpp da26a5b 
>   plugins/cli7zplugin/cliplugin.cpp 51480bc 
>   plugins/clirarplugin/cliplugin.cpp 62d2078 
>   plugins/clizipplugin/cliplugin.cpp db8dcea 
> 
> Diff: https://git.reviewboard.kde.org/r/124468/diff/
> 
> 
> Testing
> -------
> 
> Tested opening zip and rar archives with comments.
> 
> 
> File Attachments
> ----------------
> 
> KMessageWidget
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/25/df1f1b4f-cb74-4f9a-be85-0658ca6a8bbb__support-comments-1.png
> Viewing a comment.
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/25/136466f5-e757-4c85-a03e-7909a7e860e5__support-comments-2.png
> Show Comment menu item
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/25/cce3359d-edf3-4984-9eaf-a193e944060e__support-comments-3.png
> 
> 
> Thanks,
> 
> Ragnar Thomsen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150726/6a10b630/attachment-0001.html>