Review Request 120484: Small changes in Ark service menu strings

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120484/#review68797
-----------------------------------------------------------

Ship it!


Looks sane to me. If you're still in doubt you can contact the usability folks, but IMHO we're good to go.

- Raphael Kubo da Costa


On June 11, 2015, 9:02 p.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120484/
> -----------------------------------------------------------
> 
> (Updated June 11, 2015, 9:02 p.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Bugs: 198227
>     http://bugs.kde.org/show_bug.cgi?id=198227
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> The bug 198227 has a couple of points still not addressed.
> In the Ark service menu, the string `Compress To...` might be changed to `Compress to...`. 
> The other point was to change the string `Here` to `Here (as TAR.GZ)`, and while I did it in this review, I think this needs to be discussed here.
> 
> The fact: currently Ark has two desktop actions with different names but the same effect: `Compress -> Here` and `Compress -> As TAR.GZ Archive`, i.e. the effect is a tar.gz archive being created. I see four options:
> 
> 1. Change the action `Here` to `Here (as TAR.GZ)`. In this way the novice user will still see the word *here*, while the advanced user will know which archive format is going to be used. But in this case the action `Compress -> As TAR.GZ Archive` would become a duplicate both in the name (well, kind of) and in the effect. In other words, the users will be confused about which of the two actions to choose.
> 2. Change the action `Here` to `Here (as TAR.GZ)` and remove the action `Compress -> As TAR.GZ Archive`. Now there are no duplicates and no confusion.
> 3. Remove the action `Here`. No more duplicates and no more confusion, but now the novice user will not see the word *here* (assuming that this was the reason why the `Here` action has been created).
> 4. Stick with `Here` and `Compress -> As TAR.GZ Archive`, so different names but same effect. If so, the bug should be closed, except maybe for `Compress To...` becoming `Compress to...`
> 
> So, I would go with 2. (this means I'd need to update the diff)
> What do you guys think?
> 
> 
> Diffs
> -----
> 
>   app/ark_addtoservicemenu.desktop 85ae4106870b83a50967ee99bc49779d788f924a 
> 
> Diff: https://git.reviewboard.kde.org/r/120484/diff/
> 
> 
> Testing
> -------
> 
> Compile and check if the strings are changed.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150722/2d194567/attachment.html>