Review Request 121997: Implement configuration dialog in Ark

[Elvis Angelaccio]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121997/
-----------------------------------------------------------

(Updated July 22, 2015, 10:22 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Utils and Raphael Kubo da Costa.


Changes
-------

Submitted with commit 7850a0aabf2149eab5d53d3e9fea57c6113cc563 by Elvis Angelaccio to branch Applications/15.08.


Bugs: 165314
    http://bugs.kde.org/show_bug.cgi?id=165314


Repository: ark


Description
-------

This patch implements the standard Configuration Dialog (i.e. using `KConfigDialog`) in Ark, as one would expect from a KDE application. 
This feature has been requested in more than one bug. I choosed to target bug 165314 since the others are more like "add the config dialog to implement the feature *foo*".

The widgets showed in the config dialog are provided by the Ark `Part` interface (just one widget for now). This should help to show the Ark settings in, for instance, Konqueror's config dialog. A similar approach is done in Kate and Cantor, from what I have seen.

I don't like very much the `document-save` icon used for the Extraction page, but I couldn't find any better.


Diffs
-----

  app/mainwindow.h a7b23984931d83cdd26722663d49e02457c25af6 
  app/mainwindow.cpp 6511d548e0657f670c3823f63b13c4ca4fa98036 
  kerfuffle/CMakeLists.txt 8d118033571b447f6ce09140417f25abcf9d2f79 
  kerfuffle/ark.kcfg a5731fb1253b4166e7a41f7c70ea8b644658f1e5 
  kerfuffle/extractionsettings.ui PRE-CREATION 
  kerfuffle/extractionsettingspage.h PRE-CREATION 
  kerfuffle/extractionsettingspage.cpp PRE-CREATION 
  kerfuffle/previewsettings.ui PRE-CREATION 
  kerfuffle/previewsettingspage.h PRE-CREATION 
  kerfuffle/previewsettingspage.cpp PRE-CREATION 
  kerfuffle/settingspage.h PRE-CREATION 
  kerfuffle/settingspage.cpp PRE-CREATION 
  part/interface.h 40f590284502d23a2a4ffaa333bfd5b63e6ec773 
  part/part.h 92832c1e914e3797caddefb41e49f95f0924a782 
  part/part.cpp 9cd27804f633323b7dca9baf4c232754af8ef1b8 

Diff: https://git.reviewboard.kde.org/r/121997/diff/


Testing
-------

Compile and run, then try to change some settings and check that they persist.


File Attachments
----------------

extraction-settings.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/06/03/3dfe3110-4f46-4c14-9b19-79060577a4c9__extraction-settings.png
preview-settings1.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/06/04/8a1600b1-64a7-43fa-87e8-0c84e054d801__preview-settings1.png
preview-settings2.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/06/04/f687f5ea-3f2e-48b0-b204-92e3fbdf23e7__preview-settings2.png


Thanks,

Elvis Angelaccio

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150722/b4130c42/attachment-0001.html>