Review Request 121997: Implement configuration dialog in Ark

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121997/#review82788
-----------------------------------------------------------


I think there are only a few minor issues left which I wrote below. Additionally, so far the code in `kerfuffle/` is all 2-BSD licensed, so it would be good if the new code could maintain the same license.


part/interface.h (line 27)
<https://git.reviewboard.kde.org/r/121997/#comment57102>

    Minor coding style issue: IIRC normally forward-class declarations inside namespaces are still declared in a separate line even if there's only one of them.



part/part.cpp (line 537)
<https://git.reviewboard.kde.org/r/121997/#comment57103>

    You can make this `static`.


- Raphael Kubo da Costa


On July 16, 2015, 1:02 p.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121997/
> -----------------------------------------------------------
> 
> (Updated July 16, 2015, 1:02 p.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Bugs: 165314
>     http://bugs.kde.org/show_bug.cgi?id=165314
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> This patch implements the standard Configuration Dialog (i.e. using `KConfigDialog`) in Ark, as one would expect from a KDE application. 
> This feature has been requested in more than one bug. I choosed to target bug 165314 since the others are more like "add the config dialog to implement the feature *foo*".
> 
> The widgets showed in the config dialog are provided by the Ark `Part` interface (just one widget for now). This should help to show the Ark settings in, for instance, Konqueror's config dialog. A similar approach is done in Kate and Cantor, from what I have seen.
> 
> I don't like very much the `document-save` icon used for the Extraction page, but I couldn't find any better.
> 
> 
> Diffs
> -----
> 
>   app/mainwindow.h 5dd7fb82e3f5a48c9bdbefcef2a83c3e990482ca 
>   app/mainwindow.cpp aee823174a0b731e125381be09181938cdb6dd7d 
>   kerfuffle/CMakeLists.txt 8c56b4f46090c924f0848ad229b6a3779af1f1f3 
>   kerfuffle/ark.kcfg 97d2086688698e96c429def089c50ff3cdbe4c4e 
>   kerfuffle/extractionsettings.ui PRE-CREATION 
>   kerfuffle/extractionsettingspage.h PRE-CREATION 
>   kerfuffle/extractionsettingspage.cpp PRE-CREATION 
>   kerfuffle/previewsettings.ui PRE-CREATION 
>   kerfuffle/previewsettingspage.h PRE-CREATION 
>   kerfuffle/previewsettingspage.cpp PRE-CREATION 
>   kerfuffle/settingspage.h PRE-CREATION 
>   kerfuffle/settingspage.cpp PRE-CREATION 
>   part/interface.h 40f590284502d23a2a4ffaa333bfd5b63e6ec773 
>   part/part.h 5379b9fc1aaa4ce451c8b1745ca46ee78630b005 
>   part/part.cpp 09fe1cbfcc7f4345fe12932055dcb041f50abb7b 
> 
> Diff: https://git.reviewboard.kde.org/r/121997/diff/
> 
> 
> Testing
> -------
> 
> Compile and run, then try to change some settings and check that they persist.
> 
> 
> File Attachments
> ----------------
> 
> extraction-settings.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/06/03/3dfe3110-4f46-4c14-9b19-79060577a4c9__extraction-settings.png
> preview-settings1.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/06/04/8a1600b1-64a7-43fa-87e8-0c84e054d801__preview-settings1.png
> preview-settings2.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/06/04/f687f5ea-3f2e-48b0-b204-92e3fbdf23e7__preview-settings2.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150721/89ed2453/attachment.html>