Review Request 121997: Implement configuration dialog in Ark

[Thomas Pfeiffer]

> On Jan. 12, 2015, 1:58 nachm., Thomas Pfeiffer wrote:
> > Here is a UI review:
> > 1. Please get rid of the group boxes, they don't serve any purpose here whatsoever.
> > 2. Having a separate tab for the "Show info panel" checkbox doesn't make sense. Actually, this is an option that could very well stay directly in the settings menu instead of the config dialog, because it's simply showing vas, hiding a UI elemement. Most other applications keep such options in the Settings or View menu. The settings dialog is usually reserved for settings on which changes are not immediately visible in the UI, just like "Show status bar". So please move it back to the Settings menu.
> 
> Elvis Angelaccio wrote:
>     Thanks for your review. What about the scroll area container? I just realized that most applications don't use it at all (e.g. Dolphin, Kate, Konsole, Gwenview, ...).
>     Here the resulting screenshots:
>     
>     * without scroll area: http://abload.de/img/ark-settingswqkg5.png
>     * with scroll area: http://abload.de/img/ark-settings-scrollareukmv.png

Since there are so few settings that it will never need to scroll, you should remove the scroll area container as well.

And now that there is only one "tab", does the sidebar even still have to be shown? It doesn't really have any use anymore now.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121997/#review73857
-----------------------------------------------------------


On Jan. 12, 2015, 12:14 nachm., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121997/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2015, 12:14 nachm.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Bugs: 165314
>     http://bugs.kde.org/show_bug.cgi?id=165314
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> This patch implements the standard Configuration Dialog (i.e. using `KConfigDialog`) in Ark, as one would expect from a KDE application. 
> This feature has been requested in more than one bug. I choosed to target bug 165314 since the others are more like "add the config dialog to implement the feature *foo*".
> 
> The widgets showed in the config dialog are provided by the Ark `Part` interface (just one widget for now). This should help to show the Ark settings in, for instance, Konqueror's config dialog. A similar approach is done in Kate and Cantor, from what I have seen.
> 
> I don't like very much the `document-save` icon used for the Extraction page, but I couldn't find any better.
> 
> 
> Diffs
> -----
> 
>   part/ark_part.rc 044c11a562d03589314f05e86eb1d68e633ee35e 
>   part/arkconfigpage.h PRE-CREATION 
>   part/arkconfigpage.cpp PRE-CREATION 
>   part/dialogs/extractionsettings.h PRE-CREATION 
>   part/dialogs/extractionsettings.ui PRE-CREATION 
>   app/arkui.rc 6775c3310533ff164ed083da770643024947d490 
>   app/mainwindow.h 5dd7fb82e3f5a48c9bdbefcef2a83c3e990482ca 
>   app/mainwindow.cpp aee823174a0b731e125381be09181938cdb6dd7d 
>   kerfuffle/ark.kcfg 97d2086688698e96c429def089c50ff3cdbe4c4e 
>   part/CMakeLists.txt 9e384438b60322f1d51d31e40c556b2912970ceb 
>   part/interface.h 40f590284502d23a2a4ffaa333bfd5b63e6ec773 
>   part/part.h 5379b9fc1aaa4ce451c8b1745ca46ee78630b005 
>   part/part.cpp 09fe1cbfcc7f4345fe12932055dcb041f50abb7b 
>   part/dialogs/mainwindowsettings.h PRE-CREATION 
>   part/dialogs/mainwindowsettings.ui PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121997/diff/
> 
> 
> Testing
> -------
> 
> Compile and run, then try to change some settings and check that they persist.
> 
> 
> File Attachments
> ----------------
> 
> ark-settings1.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/01/12/76411a57-e9ed-4aec-8265-0608beb3f221__ark-settings1.png
> ark-settings2.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/01/12/7a82816b-17dd-4526-8424-5b0c1162ca76__ark-settings2.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150112/ab15c61b/attachment.html>