Review Request 121842: Properly build libarchive plugin

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121842/#review73096
-----------------------------------------------------------

Ship it!


Looks good to me, thanks!

- Raphael Kubo da Costa


On Jan. 5, 2015, 12:46 a.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121842/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2015, 12:46 a.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> As discussed in the other review, there is still some work to do after the upgrade to libarchive3:
> 
> * The libarchive plugin was indeed not built at all by cmake
> * The file `config.h.cmake` should not be needed anymore, I removed it
> * The default variables `LibArchive_INCLUDE_DIRS` and `LibArchive_LIBRARIES` need to be used to properly link the library
> 
> Let me know If I'm missing something else.
> 
> 
> Diffs
> -----
> 
>   plugins/libarchive/CMakeLists.txt 5d6d009660cd559ca8a74a897be4018c9ece133c 
>   plugins/libarchive/libarchivehandler.cpp 0fba52864523bf07ba8c898aa6b15cd867001de6 
>   CMakeLists.txt b17c30b4f0f57db6e6cc1e8ee77c5fe5e8b32e77 
>   config.h.cmake 1d0b1cb4e5fa9db7e75286e7141a355e92deda84 
>   plugins/CMakeLists.txt 33395327a505dba15258e38f8bd63fa6cc403071 
> 
> Diff: https://git.reviewboard.kde.org/r/121842/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150104/80603908/attachment.html>