Review Request 121342: Switch away from libarchive deprecated functions

[Ivailo Monev]

> On Dec. 4, 2014, 9:28 p.m., Raphael Kubo da Costa wrote:
> > This means Ark won't built with libarchive 2.8 anymore, right? If so, I'd rather do it for frameworks and leave the KDE4 version supporting a wider range of libarchive releases.
> 
> Elvis Angelaccio wrote:
>     Yes, that's right. Should I commit on `frameworks` then?
> 
> Raphael Kubo da Costa wrote:
>     I think we can do a broader API update here. For example, that same wiki page says the `ARCHIVE_COMPRESSION_*` macros are not part of libarchive3 (I still have them defined here for compatibility, though), so there's room for more improvements.
> 
> Elvis Angelaccio wrote:
>     That's fine for me. Feel free to discard this review, it makes sense to create a new one later.
> 
> Raphael Kubo da Costa wrote:
>     I'm fine with updating this review once you have the bandwidth to work on it instead of opening a new one, after all my suggestion is just an extension of the original idea behind this patch.
> 
> Ivailo Monev wrote:
>     You need to update the FindLibArchive cmake module to look for the new API too.
> 
> Elvis Angelaccio wrote:
>     Thanks, updated now.
> 
> Ivailo Monev wrote:
>     There are additional checks in ark/plugins/libarchive/CMakeLists.txt like HAVE_LIBARCHIVE_CAB_SUPPORT and HAVE_LIBARCHIVE_RPM_SUPPORT. Also, you can drop the CLI plugins for Zip and 7z formats and update the MIME types that are supported by the libarchive plugin as these formats are supported since 3.0.0. It may be too much for a single review request but I just want to let you know.
> 
> Elvis Angelaccio wrote:
>     Thanks, indeed there are some checks still to be removed. I'm not sure if I am supposed to reopen this review or create a new one (let's wait what Raphael says).
>     Regarding the 7z and zip formats in libarchive, yes it's something that needs a proper discussion. For example, I have another review request for the creation of password protected archives. AFAIK, that feature would not be possible by using libarchive.
> 
> Raphael Kubo da Costa wrote:
>     Thanks everyone. Elvis, please send a new review request removing all the libarchive checks from `plugins/CMakeLists.txt` (I'm suspecting the libarchive plugin is not even being built at the moment). Ivailo, removing the CLI plugins is something else entirely: as Elvis pointed out, it has many other consequences and libarchive support for formats such as zip and rar may not be feature complete yet, so I'd rather not do anything like that without a lot of investigation.

As far as I know password protected Zip, 7z, rar archives are not supported yet by libarchive but planned. So, yes, it would make sense the keep the plugins for those formats if that feature is desired. Or, implement it in libarchive and make everyone happy - not just KDE but libarchive users too.

And yes, LIBARCHIVE_FOUND needs to be changed to LibArchive_FOUND for the plugin to be build as that is what the bundled libarchive CMake module defines.


- Ivailo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121342/#review71369
-----------------------------------------------------------


On Jan. 2, 2015, 4:39 p.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121342/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2015, 4:39 p.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> This patch replaces the deprecated `libarchive` functions used in `libarchivehandler.cpp` with their replacements.
> Quick reference: https://github.com/libarchive/libarchive/wiki/ManPageLibarchiveChanges3#Deprecated_Symbols
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt b17c30b4f0f57db6e6cc1e8ee77c5fe5e8b32e77 
>   cmake/modules/COPYING-CMAKE-SCRIPTS 4b417765f3a834ce6b0a216f6b6c0fe2d3f0bed5 
>   cmake/modules/FindLibArchive.cmake db14d7b279e67039c454fcaa82a21885feec26e0 
>   plugins/libarchive/libarchivehandler.cpp 0fba52864523bf07ba8c898aa6b15cd867001de6 
> 
> Diff: https://git.reviewboard.kde.org/r/121342/diff/
> 
> 
> Testing
> -------
> 
> After compiling all the warnings about deprecated symbols are gone.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150104/9295b881/attachment-0001.html>