Review Request 121342: Switch away from libarchive deprecated functions

[Elvis Angelaccio]

> On Gen. 1, 2015, 11:19 p.m., Raphael Kubo da Costa wrote:
> > Hi again. Sorry for the lots of back and forth in what should've been a simple patch.
> > 
> > Since we're targeting `frameworks`, we can be less conservative here and simplify a few things in one patch:
> > * We can target libarchive3, which always has those symbols we're looking for in our `FindLibArchive`. Which means we can also drop the `#ifdef` checks in the plugin.
> > * Consequently, we can also remove our `FindLibArchive.cmake` -- at the time (many years ago), it was added because CMake did not ship one, but that has not been the case since CMake 2.8.3.
> > * CMake's `FindLibArchive` sets `LibArchive_VERSION`, so we can change our `find_package()` call to something like `find_package(LibArchive 3.0.0 REQUIRED)` to make sure we're using a recent enough version.

Patch updated, it builds and compile on my KF5 test system.


- Elvis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121342/#review72887
-----------------------------------------------------------


On Gen. 2, 2015, 3:20 p.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121342/
> -----------------------------------------------------------
> 
> (Updated Gen. 2, 2015, 3:20 p.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> This patch replaces the deprecated `libarchive` functions used in `libarchivehandler.cpp` with their replacements.
> Quick reference: https://github.com/libarchive/libarchive/wiki/ManPageLibarchiveChanges3#Deprecated_Symbols
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt b17c30b4f0f57db6e6cc1e8ee77c5fe5e8b32e77 
>   cmake/modules/COPYING-CMAKE-SCRIPTS 4b417765f3a834ce6b0a216f6b6c0fe2d3f0bed5 
>   cmake/modules/FindLibArchive.cmake db14d7b279e67039c454fcaa82a21885feec26e0 
>   plugins/libarchive/libarchivehandler.cpp 0fba52864523bf07ba8c898aa6b15cd867001de6 
> 
> Diff: https://git.reviewboard.kde.org/r/121342/diff/
> 
> 
> Testing
> -------
> 
> After compiling all the warnings about deprecated symbols are gone.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150102/9d618869/attachment.html>