[Differential] [Request, 23 lines] D720: Create temporary directories on disk and not in RAM
elvisangelaccio (Elvis Angelaccio)
noreply at phabricator.kde.org
Wed Dec 30 11:29:01 UTC 2015
elvisangelaccio created this revision.
elvisangelaccio added a reviewer: rthomsen.
elvisangelaccio set the repository for this revision to rARK Ark.
elvisangelaccio added a project: Ark.
Herald added a subscriber: kde-utils-devel.
REVISION SUMMARY
Currently `CliInterface::copyFiles()` creates a temporary directory in `/tmp`, upon extraction of one or more selected files.
This does not scale well on systems where `/tmp` is mounted in RAM, if the RAM is low or if the archive has huge files.
We can simply create the temporary directory on disk. We only need to be sure that the temp dir is created on the same disk where the final destination is (otherwise we write each (possibly huge) file twice).
TEST PLAN
The QTemporaryDir is created on the same disk where the final destination is, and it autodeletes itself upon destruction.
Extracting huge files does not fill the RAM anymore.
REPOSITORY
rARK Ark
REVISION DETAIL
https://phabricator.kde.org/D720
AFFECTED FILES
kerfuffle/cliinterface.cpp
kerfuffle/cliinterface.h
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: elvisangelaccio, rthomsen
Cc: kde-utils-devel
More information about the Kde-utils-devel
mailing list