[Differential] [Request, 17 lines] D712: Don't list() if we are creating a new archive from Ark window
elvisangelaccio (Elvis Angelaccio)
noreply at phabricator.kde.org
Mon Dec 28 13:40:30 UTC 2015
elvisangelaccio created this revision.
elvisangelaccio added a reviewer: rthomsen.
elvisangelaccio set the repository for this revision to rARK Ark.
elvisangelaccio added a project: Ark.
Herald added a subscriber: kde-utils-devel.
REVISION SUMMARY
Currently if we create a new archive using the New action, Ark creates a ListJob which is obviously going to fail, since the archive does not exist yet. Previously Ark would just ignore such failing jobs, but with Ark 15.12 the clirar plugin actually parses the error message of unrar as a valid comment (see attached screenshot).
We can solve the problem at the root and only run a ListJob if the archive to be listed actually exists.
TEST PLAN
Creating a new RAR archive using the New action, does not show anymore the unrar error message as comment.
REPOSITORY
rARK Ark
REVISION DETAIL
https://phabricator.kde.org/D712
AFFECTED FILES
part/archivemodel.cpp
part/archivemodel.h
part/part.cpp
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: elvisangelaccio, rthomsen
Cc: kde-utils-devel
More information about the Kde-utils-devel
mailing list