Review Request 126360: Ark 15.12 can't open rar file with space in path correctly.

[Xuetian Weng]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126360/
-----------------------------------------------------------

(Updated Dec. 17, 2015, 6:21 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Utils and Elvis Angelaccio.


Changes
-------

Submitted with commit 24b0afbec552f56b30d91fc041fc727add5b6e58 by Weng Xuetian to branch Applications/15.12.


Repository: ark


Description
-------

The "Archive: " line can obviously contain space character, current code will take all output from unrar as comment if archive file path contains space.

This patch is only a naive change to capture all character on the Archive: line.

It seems it's possible that Comment section also contains "Archive:". So it doesn't fix all the problem. Probably parse from end would make it more robust.


Diffs
-----

  plugins/clirarplugin/cliplugin.cpp 23eb6cc 

Diff: https://git.reviewboard.kde.org/r/126360/diff/


Testing
-------

Open file with space in path, correctly file content is shown correctly.


Thanks,

Xuetian Weng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20151217/4e5b7251/attachment.html>