Review Request 126360: Ark 15.12 can't open rar file with space in path correctly.
Xuetian Weng
wengxt at gmail.com
Tue Dec 15 16:16:12 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126360/
-----------------------------------------------------------
(Updated Dec. 15, 2015, 4:16 p.m.)
Review request for KDE Utils and Elvis Angelaccio.
Repository: ark
Description
-------
The "Archive: " line can obviously contain space character, current code will take all output from unrar as comment if archive file path contains space.
This patch is only a naive change to capture all character on the Archive: line.
It seems it's possible that Comment section also contains "Archive:". So it doesn't fix all the problem. Probably parse from end would make it more robust.
Diffs (updated)
-----
plugins/clirarplugin/cliplugin.cpp 23eb6cc
Diff: https://git.reviewboard.kde.org/r/126360/diff/
Testing
-------
Open file with space in path, correctly file content is shown correctly.
Thanks,
Xuetian Weng
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20151215/eac8a438/attachment.html>
More information about the Kde-utils-devel
mailing list