Review Request 126219: [kteatime] Initialise KCrash for DrKonqui integration.

[Andreas Sturmlechner]

> On Dec. 4, 2015, 10:02 p.m., Andrius Štikonas wrote:
> > Looks ok.
> > Strange, when I ported kteatime to KF5 documentation did not say anything about needing to initialize KCrash it said linking is enough.
> > 
> > Do we still need to support KF 5.14 and less?

only if it is to be committed to 15.12 brach, in git master ofc the better initialize method is fine.


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126219/#review89136
-----------------------------------------------------------


On Dec. 2, 2015, 12:01 a.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126219/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2015, 12:01 a.m.)
> 
> 
> Review request for KDE Utils, Luigi Toscano and Andrius Štikonas.
> 
> 
> Repository: kteatime
> 
> 
> Description
> -------
> 
> KCrash was searched and linked, but effectively unused. Initialise KCrash for DrKonqui integration (as seen elsewhere, like artikulate)
> 
> Technically it's a bugfix, but effectively it is also now a _real_ new dependency. Fit for 15.12 or not? ;)
> 
> 
> Diffs
> -----
> 
>   src/main.cpp 2b5d8cce109e19511cc85c7af06d760006a0f04f 
> 
> Diff: https://git.reviewboard.kde.org/r/126219/diff/
> 
> 
> Testing
> -------
> 
> Builds and runs.
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20151205/2f342305/attachment.html>