Review Request 122001: Remove ellipsis from job name "Extracting file..."
Lasse Liehu
lasse.liehu at gmail.com
Sat Apr 18 16:48:18 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122001/#review79174
-----------------------------------------------------------
It would also be nice to properly pluralize the message, but I don't know how to get the count of files.
- Lasse Liehu
On huhti 18, 2015, 4:47 ip, Lasse Liehu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122001/
> -----------------------------------------------------------
>
> (Updated huhti 18, 2015, 4:47 ip)
>
>
> Review request for KDE Utils and Raphael Kubo da Costa.
>
>
> Repository: ark
>
>
> Description
> -------
>
> In Plasma 5 ending the name in an ellipsis doesn't look good. After the job has finished, there will be a notification like this:
>
> Extracting file...: Finished
>
> I haven't seen other KDE applications that use an ellipsis at the end of a KIO job name.
>
> Also this job name is used when extracting any number of files, so I changed it to plural.
>
>
> Diffs
> -----
>
> app/batchextract.cpp a67c045
>
> Diff: https://git.reviewboard.kde.org/r/122001/diff/
>
>
> Testing
> -------
>
> Still works.
>
>
> Thanks,
>
> Lasse Liehu
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150418/e2c35de4/attachment-0001.html>
More information about the Kde-utils-devel
mailing list