Review Request 120357: [kcalc] KF5 port: replace KLocale::formatNumber() with custom code

[Evan Teran]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120357/#review67680
-----------------------------------------------------------

Ship it!


Ship It!

- Evan Teran


On Sept. 24, 2014, 11 p.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120357/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2014, 11 p.m.)
> 
> 
> Review request for KDE Frameworks, KDE Utils, John Layt, and Evan Teran.
> 
> 
> Repository: kcalc
> 
> 
> Description
> -------
> 
> To remove the last bits of KDELibs4Support in kcalc port, I had to replace KLocale::formatNumber() with a custom function, because I found no way to format arbitrary precision numbers with QLocale.
> 
> The groupSize is hardcoded to 3, I did not find  a simple way to query QLocale.
> 
> The code also replaces all digits with locale digits; not sure if the original KLocale code did the same and if this should be applied to kcalc.
> 
> 
> Diffs
> -----
> 
>   kcalcdisplay.h 807cb009d9ab3a91646779e2489a35ed635dedb7 
>   kcalcdisplay.cpp b4e2b3bec4b11f3106765dbe5cb2aa0f7c8ceae2 
> 
> Diff: https://git.reviewboard.kde.org/r/120357/diff/
> 
> 
> Testing
> -------
> 
> Tested with german locale, which has '.' as groupSeperator, and ',' as decimalPoint.
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20140930/207af81a/attachment.html>