Review Request 120381: Add option to export/import wallets in encrypted form

Valentin Rusu kde at rusu.info
Sun Sep 28 16:50:42 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120381/#review67574
-----------------------------------------------------------

Ship it!


Ship It!

- Valentin Rusu


On Sept. 26, 2014, 8:20 p.m., Arjun AK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120381/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2014, 8:20 p.m.)
> 
> 
> Review request for KDE Utils.
> 
> 
> Bugs: 337022 and 338517
>     http://bugs.kde.org/show_bug.cgi?id=337022
>     http://bugs.kde.org/show_bug.cgi?id=338517
> 
> 
> Repository: kwalletmanager
> 
> 
> Description
> -------
> 
> The "Export as encrypted file" option collects all the `.kwl` and `.salt` files inside the kwallet directory and puts them inside a tar archive. The "Import as encrypted file" option does the opposite.
> 
> This patch fixes BUG 338517('Error code -9 when trying to import wallet data') as well as implements BUG 337022('Le kwalletmanager "export as encrypted file"'). The 'Save as' option is removed because it can lead to data loss since the `.salt` file is not copied along with the `.kwl` file.
> 
> 
> Diffs
> -----
> 
>   src/manager/CMakeLists.txt ccfce5b 
>   src/manager/kwalleteditor.h 9e09b36 
>   src/manager/kwalleteditor.cpp 00badaa 
>   src/manager/kwalletmanager.h 8d9c953 
>   src/manager/kwalletmanager.cpp a4007a3 
>   src/manager/kwalletmanager.rc 7185e7c 
> 
> Diff: https://git.reviewboard.kde.org/r/120381/diff/
> 
> 
> Testing
> -------
> 
> It compiles !
> 
> 
> Thanks,
> 
> Arjun AK
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20140928/1444fd41/attachment.html>


More information about the Kde-utils-devel mailing list