Review Request 120204: Create password-protected archives with Ark

[Elvis Angelaccio]

> On Set. 24, 2014, 10:17 p.m., Raphael Kubo da Costa wrote:
> > Thanks a lot for all the patches you've been sending, Elvis. This is mostly an FYI that I've been getting them, and will review them as soon as possible :-)

Sure, thanks. :)


- Elvis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120204/#review67399
-----------------------------------------------------------


On Set. 14, 2014, 5:06 p.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120204/
> -----------------------------------------------------------
> 
> (Updated Set. 14, 2014, 5:06 p.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Bugs: 253694
>     http://bugs.kde.org/show_bug.cgi?id=253694
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> This patch allows the users to create password-protected archives using Ark. 
> The supported plugins are `zip`, `7z` and `rar`.
> The input fields for the passwords are displayed only when the relevent mime filters are selected in the `AddDialog` window.
> 
> 
> Diffs
> -----
> 
>   plugins/clirarplugin/cliplugin.cpp f5f7b184cb9f7ee16efd74968f2e86dc83668b4d 
>   kerfuffle/cliinterface.cpp eab1c6a3200543989fd501e4d54e3e0b06b48999 
>   plugins/cli7zplugin/cliplugin.cpp 500f121de97ef395110658a6ca495298bc797b46 
>   kerfuffle/addtoarchive.h fa4608e0c0df9ea9cec3aa9e7323fb53dd1b12d3 
>   kerfuffle/addtoarchive.cpp d13e0958468e3bb1aa85606e4fd4d3cb8ef6d3c0 
>   kerfuffle/adddialog.h 7c9f03e916da3a410482be2b45ff30923dfc1f9f 
>   kerfuffle/adddialog.cpp 2950ee6e22c90c770bb3b9128243f9786989ee52 
>   kerfuffle/adddialog.ui a1c595b89202b1f2b44dc4f9c2faf68f5f655eb1 
>   plugins/clizipplugin/cliplugin.cpp 1be2a10f722865c23fba6df5c25993742ce38d69 
> 
> Diff: https://git.reviewboard.kde.org/r/120204/diff/
> 
> 
> Testing
> -------
> 
> Create `.zip`, `.7z` and `.rar` archives using the Ark `AddDialog` dialog (right click on an entry in Dolphin -> Compress -> Compress to...).
> Those archives are created as expected and their entries are marked as *Password protected*.
> If the user clicks on those entries, the standard password dialog is prompted to the user.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20140926/f82cf78b/attachment.html>