Review Request 120216: Add "open-with" action and right-click context menu to Ark

Mon Sep 15 10:43:26 UTC 2014

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120216/
-----------------------------------------------------------

(Updated Sept. 15, 2014, 10:43 a.m.)

Review request for KDE Utils and Raphael Kubo da Costa.

Bugs: 179066
    http://bugs.kde.org/show_bug.cgi?id=179066

Repository: ark

Description
-------

This review aims to bring life to this 2 years-old review: https://git.reviewboard.kde.org/r/103690/
The patch is mostly the same, but the issues pointed by Raphael should now be fixed.
In particular, the default Ark behavior is unchanged: when an entry is double clicked, the preview is showed (instead of launching the default application of that entry).

Diffs (updated)
-----

  part/archiveview.h daac59b1322047f089c6d51024ba36f92e9d2439 
  part/archiveview.cpp 6b9918df732758eb4146a97c3b7250e1423400e8 
  part/ark_part.rc 044c11a562d03589314f05e86eb1d68e633ee35e 
  part/part.h 5379b9fc1aaa4ce451c8b1745ca46ee78630b005 
  part/part.cpp b4ebcd27c462d2b8037b5ea40c56969eda71bdcb 

Diff: https://git.reviewboard.kde.org/r/120216/diff/

Testing
-------

Open an existing archive, right-click on an entry, the context menu is showed and and the "Open With..." action is available.

Thanks,

Elvis Angelaccio

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20140915/7099292f/attachment.html>