Review Request 120064: Reset info panel and window caption when an archive fails to open

[Raphael Kubo da Costa]

> On Sept. 6, 2014, 7:13 p.m., Raphael Kubo da Costa wrote:
> > http://commits.kde.org/ark/03b6de3cfc7519d88c0c026a4a9737f5604d6a99
> > I referenced the wrong review request there :-(
> 
> Mathias Tillman wrote:
>     So you did :( Does it matter though, or is it just for appearances sake?

The commit can't be changed, but I've mentioned the right number in the bug request in case someone looking at the commit log wants to find out the actual review.


- Raphael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120064/#review65923
-----------------------------------------------------------


On Sept. 6, 2014, 7:15 p.m., Mathias Tillman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120064/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2014, 7:15 p.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Bugs: 245705
>     http://bugs.kde.org/show_bug.cgi?id=245705
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> When opening an archive that for whatever reason fails to load (because it's corrupt, or an invalid format) the archive appears to be open when it is not in fact open. This patch fixes that by resetting the open archive, info panel name and window caption.
> 
> 
> Diffs
> -----
> 
>   part/part.cpp b4ebcd27c462d2b8037b5ea40c56969eda71bdcb 
> 
> Diff: https://git.reviewboard.kde.org/r/120064/diff/
> 
> 
> Testing
> -------
> 
> I have tried opening both archives that fail to load and ones that work.
> 
> 
> Thanks,
> 
> Mathias Tillman
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20140906/6df56f86/attachment.html>