Review Request 120064: Reset info panel and window caption when an archive fails to open

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120064/#review65918
-----------------------------------------------------------

Ship it!


Thank you for the patch. It looks like you don't have a commit account, so I'll land the patch with the change I mentioned below.


part/part.cpp
<https://git.reviewboard.kde.org/r/120064/#comment46046>

    Please terminate the sentence with a period.


- Raphael Kubo da Costa


On Sept. 5, 2014, 2:29 p.m., Mathias Tillman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120064/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2014, 2:29 p.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Bugs: 245705
>     http://bugs.kde.org/show_bug.cgi?id=245705
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> When opening an archive that for whatever reason fails to load (because it's corrupt, or an invalid format) the archive appears to be open when it is not in fact open. This patch fixes that by resetting the open archive, info panel name and window caption.
> 
> 
> Diffs
> -----
> 
>   part/part.cpp b4ebcd27c462d2b8037b5ea40c56969eda71bdcb 
> 
> Diff: https://git.reviewboard.kde.org/r/120064/diff/
> 
> 
> Testing
> -------
> 
> I have tried opening both archives that fail to load and ones that work.
> 
> 
> Thanks,
> 
> Mathias Tillman
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20140906/c39b6623/attachment.html>